[libcxx-commits] [PATCH] D152617: [libc++][spaceship] P1614R2: Added `operator==` to `slice`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this! I would like to land D152297 <https://reviews.llvm.org/D152297> first for this one too. But this needs some addition work.



================
Comment at: libcxx/include/valarray:410
+
+    friend bool operator==(const slice& __x, const slice& __y);
+
----------------
Note this function should be a hidden friend per http://eel.is/c++draft/hidden.friends.


================
Comment at: libcxx/test/std/numerics/numarray/class.slice/slice.ops/slice.ops.pass.cpp:18
+
+int main(int, char**) {
+  {
----------------
Why not use the normal test macros instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152617/new/

https://reviews.llvm.org/D152617