[libcxx-commits] [PATCH] D152615: [libc++][spaceship] P1614R2: Removed ops from `complex`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jun 10 06:12:59 PDT 2023


Mordante requested changes to this revision.
Mordante added a comment.
This revision now requires changes to proceed.

In general LGTM, modulo one nit. I would like to land D152297 <https://reviews.llvm.org/D152297> first and directly update the status page.



================
Comment at: libcxx/include/complex:153
+template<class T> bool operator==(const complex<T>&, const T&);               // constexpr in C++14
+template<class T> bool operator==(const T&, const complex<T>&);               // removed in C++20
+template<class T> bool operator!=(const complex<T>&, const complex<T>&);      // removed in C++20
----------------
We keep all information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152615/new/

https://reviews.llvm.org/D152615



More information about the libcxx-commits mailing list