[libcxx-commits] [PATCH] D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D152297#4411014 <https://reviews.llvm.org/D152297#4411014>, @H-G-Hristov wrote:

> @Mordante Do we need to update the "Release Notes" also?

I think we can wait. I really hope we can do all of P1614 <https://reviews.llvm.org/P1614> before the next release and just mark it as done.
The next release will be branched at the end of July.

Thanks a lot for updating the status!
In general it looks great, just a few minor points. Can you ping me on Discord after updating the patch. Then I will quickly do a final check and can we land this.



================
Comment at: libcxx/docs/Status/SpaceshipPapers.csv:3
 `P1614R2 <https://wg21.link/P1614>`_,The Mothership has Landed,|In Progress|,
-`P2404R0 <https://wg21.link/P2404>`_,"Relaxing equality_comparable_with's, totally_ordered_with's, and three_way_comparable_with's common reference requirements to support move-only types",,
+`P2404R3 <https://wg21.link/P2404>`_,"Relaxing equality_comparable_with's, totally_ordered_with's, and three_way_comparable_with's common reference requirements to support move-only types",,
 `LWG3330 <https://wg21.link/LWG3330>`_,Include <compare> from most library headers,"|Complete|","13.0"
----------------
H-G-Hristov wrote:
> Mordante wrote:
> > 
> I noticed this but it seems to work as expected and redirect to the most current version so I left it unchanged. Do you still want me to update it?
> 
> PS. DONE
FYI typically this works, but sometimes a new revision of the paper is posted after it has been accepted by the C++ Committee. In these cases we still implement the accepted revision and not the new one.

Note this is very rare.


================
Comment at: libcxx/docs/Status/SpaceshipProjects.csv:92
 | Hristo Hristov",|Complete|
+| `[array.overview] <https://wg21.link/array.overview>`_ (`general <https://wg21.link/container.opt.reqmts>`_),| `array`,None,Unassigned,|Nothing To Do|
 | `[associative.map.syn] <https://wg21.link/associative.map.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),"| `map <https://reviews.llvm.org/D145976>`_
----------------
Please check whether the suggested markup is correct.


================
Comment at: libcxx/docs/Status/SpaceshipProjects.csv:119
+"| `[istreambuf.iterator] <https://wg21.link/istreambuf.iterator>`_
+| `[istreambuf.iterator.ops] <https://wg21.link/istreambuf.iterator.ops>`_",| remove ops `istream_iterator`,None,Unassigned,|Not Started|
+- `5.9 Clause 24: Ranges library <https://wg21.link/p1614r2#clause-24-ranges-library>`_,,,,
----------------



================
Comment at: libcxx/docs/Status/SpaceshipProjects.csv:158
 | `chrono::year_month_day <https://reviews.llvm.org/D129887>`_
 | `chrono::year_month_day_last <https://reviews.llvm.org/D129887>`_",None,Mark de Wever,|Complete|
 "| `[time.zone.nonmembers] <https://wg21.link/time.zone.nonmembers>`_
----------------
Can you add a new group here for removals of `operator!=`. The missing entries are the weekdays:
- weekday
- weekday_indexed
- weekday_last
- month_weekday
- month_weekday_last
- year_month_weekday
- year_month_weekday_last

It think it makes sense to do this in one patch. If you're interested the calendar has been added in C++20, to the operators can be removed.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152297/new/

https://reviews.llvm.org/D152297