[libcxx-commits] [PATCH] D151896: [libc++] Implement C++20 P0408R7 (Efficient Access to basic_stringbuf's Buffer)

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/sstream:374-375
+    void swap(basic_stringbuf& __rhs)
+        _NOEXCEPT_(allocator_traits<allocator_type>::propagate_on_container_swap::value ||
+                   allocator_traits<allocator_type>::is_always_equal::value);
 
----------------
Why do you add a conditional noexcept without any guards here?


================
Comment at: libcxx/include/sstream:378
     // [stringbuf.members] Member functions:
-    string_type str() const;
-    void str(const string_type& __s);
+    string_type str() const _LIBCPP_REF_SINCE_CXX20;
+    void str(const string_type& __s) {
----------------
Otherwise this is super confusing IMO. The extra bits should fix your problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151896/new/

https://reviews.llvm.org/D151896