[libcxx-commits] [PATCH] D152379: [libc++] Extract format_string from filesystem_common.h

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM. I noticed this reporting code is quite C-ish. I think once C++ has transcoding we could change this code to use transcoding and std::format instead.



================
Comment at: libcxx/src/filesystem/format_string.h:12
+
+#include <__assert>
+#include <array>
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152379/new/

https://reviews.llvm.org/D152379