[libcxx-commits] [PATCH] D152378: [libc++][filesystem] Use _LIBCPP_HIDE_FROM_ABI in common headers

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 7 09:25:48 PDT 2023


philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

I don't think there is any need to mark the functions as `_LIBCPP_HIDE_FROM_ABI`. These are all implementation details of the dylib, which is built with `-fvisibility=hidden`, so these symbols can never escape the dylib, making this pure noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152378/new/

https://reviews.llvm.org/D152378



More information about the libcxx-commits mailing list