[libcxx-commits] [PATCH] D144362: [libcxx] <experimental/simd> Add ABI tags, class template simd/simd_mask implementations. Add related simd traits and tests.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D144362#4402252 <https://reviews.llvm.org/D144362#4402252>, @Joy12138 wrote:

> @philnik Hi! Could you please help me check the CI errors?
>
> Last time it prompted me to remove the following statement in transitive includes of cxx23 and cxx26.
>
>   *** 174,179 ****
>   
>   --- 174,180 ----
>   
>     experimental/regexregex
>   
>     experimental/setexperimental/memory_resource
>   
>     experimental/setset
>   
>   - experimental/simdcstddef
>   
>     experimental/stringexperimental/memory_resource
>   
>     experimental/stringstring
>   
>     experimental/type_traitsinitializer_list
>   
>   
>   
>   error: command failed with exit status: 1
>
> But this time after I removed, it prompted me to add.
>
>   *** 174,179 ****
>   
>   --- 174,180 ----
>   
>     experimental/regexregex
>   
>     experimental/setexperimental/memory_resource
>   
>     experimental/setset
>   
>   + experimental/simdcstddef
>   
>     experimental/stringexperimental/memory_resource
>   
>     experimental/stringstring
>   
>     experimental/type_traitsinitializer_list
>   
>   
>   
>   error: command failed with exit status: 1

It looks to me like adding it is the correct thing. Do you know which bot didn't like the added line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144362/new/

https://reviews.llvm.org/D144362