[libcxx-commits] [PATCH] D152168: [libc++] Roll up fstream support into filesystem support

Mon Jun 5 13:17:29 PDT 2023

mstorsjo added a comment.

In D152168#4396660 <https://reviews.llvm.org/D152168#4396660>, @ldionne wrote:

> In D152168#4396140 <https://reviews.llvm.org/D152168#4396140>, @philnik wrote:
>
>> LGTM, but #libc_vendors <https://reviews.llvm.org/tag/libc_vendors/> should be aware of this.
>
> Indeed. In particular, heads up @mstorsjo and @rnk for Windows impact.

With this in place, we really should go ahead with D134912 <https://reviews.llvm.org/D134912> too, since I'm fairly sure that `<fstream>` is somewhat widely used on Windows even if `<filesystem>` is less common.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152168/new/

https://reviews.llvm.org/D152168