[libcxx-commits] [PATCH] D151629: [libc++][ranges] Implement P2494R2 (Relaxing range adaptors to allow for move only types)

[Yurong via Phabricator via libcxx-commits]

yronglin marked an inline comment as done.
yronglin added a comment.

Sorry for the late reply and thanks a lot for your review!



================
Comment at: libcxx/include/__ranges/movable_box.h:10
+
+#ifndef _LIBCPP___RANGES_MOVABLE_BOX_H
+#define _LIBCPP___RANGES_MOVABLE_BOX_H
----------------
var-const wrote:
> The formatting changes make it harder to see things that are relevant to the proposal in this file. Can you clang-format `copyable_box.h` in a separate patch and rebase this patch on that?
Ok, I'll rename copyable_box.h -> movable_box.h and formart in a separate patch.


================
Comment at: libcxx/include/__ranges/movable_box.h:33
+
+// __movable_box allows turning a type that is copy-constructible (but maybe not copy-assignable) into
+// a type that is both copy-constructible and copy-assignable. It does that by introducing an empty state
----------------
var-const wrote:
> Is this comment up-to-date?
Oops, It need update.


================
Comment at: libcxx/include/__ranges/single_view.h:40
+public:
+  _LIBCPP_HIDE_FROM_ABI single_view()
+    requires default_initializable<_Tp>
----------------
var-const wrote:
> Can you please undo the formatting change? It makes it harder to see the parts of the diff that implement the proposal.
OK, I'll undo format changes,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151629/new/

https://reviews.llvm.org/D151629