[libcxx-commits] [PATCH] D151792: [libc++][NFC] Granularise <thread> header

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/thread:93
+#include <__thread/formatter.h>
 #include <__thread/poll_with_backoff.h>
+#include <__thread/this_thread.h>
----------------
ldionne wrote:
> Let's remove those includes since they don't contribute to the public API of `<thread>`.
> 
> At first we tried to systematically include all headers from `<__foo/*.h>` inside `<foo>`, but we noticed it didn't work (I think it was causing circular dependency issues but I think @Mordante might remember more context) so now I guess the only consistent thing we can do is include only the ones that contribute to the public API of `<foo>`.
I don't exactly recall. I thought still wanted to include all `<__foo/*.h>`. That might be less important nowadays since most headers use the granularized parts of a header instead of the entire header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151792/new/

https://reviews.llvm.org/D151792