[libcxx-commits] [PATCH] D149672: [libc++][format] Fixes UTF-8 continuation.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp:507-512
+  // http://unicode.org/review/pr-121.html
+  test_format(R"("a\x{f1}\x{80}\x{80}\x{e1}\x{80}\x{c2}b")"sv,
+              "{:?}",
+              "a"
+              "\xf1\x80\x80\xe1\x80\xc2"
+              "b");
----------------
tahonermann wrote:
> I'm not sure what purpose is served by the reference to PR-121 here. The test appears to demonstrate that code unit values are preserved as escaped values which, I think, is the right behavior according to the C++ standard, but is not a match for any of the PR-121 policies.
That is a left over debug message for me, removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149672/new/

https://reviews.llvm.org/D149672