[libcxx-commits] [PATCH] D150831: [libc++] Implement ranges::ends_with

Zijun Zhao via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 2 11:53:09 PDT 2023


ZijunZhao added inline comments.


================
Comment at: libcxx/include/__algorithm/ranges_ends_with.h:62
+    auto __unwrapped2 = std::__unwrap_range(std::move(__first2), std::move(__last2));
+    return std::__equal_impl(
+        std::move(__unwrapped1.first),
----------------
var-const wrote:
> Question: why are we calling `__equal_impl` rather than `ranges::equal`?
Because if we use `ranges::equal` , projections.pass.cpp and comparator.pass.cpp will fail for being copied.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150831/new/

https://reviews.llvm.org/D150831



More information about the libcxx-commits mailing list