[libcxx-commits] [PATCH] D144362: [libcxx] <experimental/simd> Add ABI tags, class template simd/simd_mask implementations. Add related simd traits and tests.

[Yin Zhang via Phabricator via libcxx-commits]

Joy12138 marked an inline comment as done.
Joy12138 added inline comments.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:20-21
+
+using integral_no_bool_types =
+    types::concatenate_t<types::character_types, types::signed_integer_types, types::unsigned_integer_types>;
+using arithmetic_no_bool_types = types::concatenate_t<integral_no_bool_types, types::floating_point_types>;
----------------
philnik wrote:
> This is just `integer_types`, right?
No, it is not the same.

The first template parameter of the `simd` class does not accept input of bool type. And the vector type corresponding to bool type is defined by `simd_mask` class.

In "type_algorithms.h", `integer_types` has the following definition:

```
// libcxx/test/support/type_algorithms.h:98
using integral_types = concatenate_t<character_types, signed_integer_types, unsigned_integer_types, type_list<bool> >;
```
It contains type bool. And we need arithmetic types without bool to test class `simd`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144362/new/

https://reviews.llvm.org/D144362