[libcxx-commits] [PATCH] D151913: [libc++] Make sure we use POSIX paths in header_information.py

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

LGTM!



================
Comment at: libcxx/utils/libcxx/test/header_information.py:133
 
-monorepo_root = pathlib.Path(
-    os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))))
-)
-include = pathlib.Path(os.path.join(monorepo_root, "libcxx", "include"))
-test = pathlib.Path(os.path.join(monorepo_root, "libcxx", "test"))
-assert monorepo_root.exists()
+libcxx_root = pathlib.Path(os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))))
+include = pathlib.Path(os.path.join(libcxx_root, "include"))
----------------
I really dislike this nested `os.path.dirname`, but it is pre-existing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151913/new/

https://reviews.llvm.org/D151913