[libcxx-commits] [PATCH] D155312: [libc++] Use _Complex for multiplication and division of complex floating point types

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Can you modify the CI file to run with a limited number of configurations, but enable all platform.

Also fix the non floating point test to be fixed.

That way I can get a better view of the impact of the changes.



================
Comment at: libcxx/test/std/numerics/complex.number/complex.member.ops/divide_equal_complex.pass.cpp:28
     c /= c2;
-    assert(c.real() == 1.5);
-    assert(c.imag() == 2.5);
+    assert(c.real() >= T(1.499999999999999));
+    assert(c.real() <= T(1.500000000000001));
----------------
I would like to test with an epsion and not `>=`.
I think the values used in the test should give an exact result.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155312/new/

https://reviews.llvm.org/D155312