[libcxx-commits] [PATCH] D156039: [libc++] Optimize ranges::find for vector<bool>

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 31 09:01:11 PDT 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM with the comments addressed.



================
Comment at: libcxx/benchmarks/algorithms/find.bench.cpp:61
+}
+BENCHMARK(bm_vector_bool_find)->DenseRange(1, 8)->Range(16, 1 << 20);
+
----------------
please add the benchmarks to the commit message.


================
Comment at: libcxx/include/__bit/invert_if.h:23-27
+  if (_Invert) {
+    return ~__v;
+  } else {
+    return __v;
+  }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156039/new/

https://reviews.llvm.org/D156039



More information about the libcxx-commits mailing list