[libcxx-commits] [PATCH] D155325: [libc++][PSTL] Fix std::copy frontend dispatching

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 31 08:49:25 PDT 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo nits



================
Comment at: libcxx/test/libcxx/algorithms/pstl.robust_against_customization_points_not_working.pass.cpp:295
   assert(std::pstl_none_of_called);
+  (void)std::copy(TestPolicy{}, std::begin(a), std::end(a), std::begin(a));
+  assert(std::pstl_copy_called);
----------------
Since the function is not nodiscard and shouldn't be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155325/new/

https://reviews.llvm.org/D155325



More information about the libcxx-commits mailing list