[libcxx-commits] [PATCH] D156550: [libc++][test] Fixes using modules in the test suite.

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 31 08:27:32 PDT 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM with TODOs added.



================
Comment at: libcxx/utils/libcxx/test/dsl.py:461-463
+    config.substitutions = _appendToSubstitution(
+       config.substitutions, "%{link_flags}",  os.path.join(build, "libc++std.a")
+    )
----------------
Please add a TODO to fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156550/new/

https://reviews.llvm.org/D156550



More information about the libcxx-commits mailing list