[libcxx-commits] [PATCH] D156573: [libcxx] [test] Deduplicate setting parameters for clangcl test configs. NFC.

Sun Jul 30 04:48:37 PDT 2023

mstorsjo added a comment.

In D156573#4544760 <https://reviews.llvm.org/D156573#4544760>, @Mordante wrote:

> No objections from my perspective. Please wait for @andrewng's approval before landing.

Any preference on landing (and adapting) this to go in before the two dependencies (D155561 <https://reviews.llvm.org/D155561> and D155562 <https://reviews.llvm.org/D155562>), or keeping it where it is now afterwards? I can adapt it so this goes in first too. The second one of those dependencies isn’t approved yet (and depends on the requirement being raised to clang 16, which I guess we can do now that the branch is made - but holding off of that for a while might ease backporting).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156573/new/

https://reviews.llvm.org/D156573