[libcxx-commits] [PATCH] D155486: Optimize basic_string's memory usage

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 29 06:07:36 PDT 2023


Mordante added a subscriber: philnik.
Mordante added a comment.

In D155486#4532334 <https://reviews.llvm.org/D155486#4532334>, @mvels wrote:

> BTW: I did not understand the Apple max_size.pass failure, I adjusted the test and they all pass (check-cxx) on my local git repo on x86.

On the backdeployment targets the new code uses the old version of the dylib. My suspicion is there is an ABI incompatibility. @philnik do you see an issue in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155486/new/

https://reviews.llvm.org/D155486



More information about the libcxx-commits mailing list