[libcxx-commits] [PATCH] D156508: [libc++][Modules] Fix a few module related warnings

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D156508#4544074 <https://reviews.llvm.org/D156508#4544074>, @iana wrote:

> I can't reproduce the warning in `check-cxx` or `run-buildbot generic-modules` and I don't know why. It looks like the tests have `-Werror=all`, and just in case I tried adding `-Werror=undefined-inline`, but they still come up green. So I'm stumped why this seems to only reproduce when I install libc++ into my macOS SDK, but it seems like a serious problem with an easy fix that we'd better put into llvm 17.

I think the changes are not too intrusive for LLVM-17 so I'm fine with backporting it.
LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156508/new/

https://reviews.llvm.org/D156508