[libcxx-commits] [PATCH] D156585: [libc++][print] Make `<print>` tests require file system support.

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 28 18:23:46 PDT 2023


var-const created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
var-const requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

`print` functions require `FILE` and `stdout` to be available and cause
compilation errors on platforms that don't support the file system.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156585

Files:
  libcxx/test/std/input.output/iostream.format/print.fun/lit.local.cfg
  libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
  libcxx/utils/generate_feature_test_macro_components.py
  libcxx/utils/libcxx/test/header_information.py


Index: libcxx/utils/libcxx/test/header_information.py
===================================================================
--- libcxx/utils/libcxx/test/header_information.py
+++ libcxx/utils/libcxx/test/header_information.py
@@ -45,7 +45,7 @@
     "locale.h": "// UNSUPPORTED: no-localization",
     "mutex": "// UNSUPPORTED: no-threads, c++03",
     "ostream": "// UNSUPPORTED: no-localization",
-    "print": "// UNSUPPORTED: availability-fp_to_chars-missing", # TODO PRINT investigate
+    "print": "// UNSUPPORTED: no-filesystem, c++03, c++11, c++14, c++17, c++20, availability-fp_to_chars-missing", # TODO PRINT investigate
     "regex": "// UNSUPPORTED: no-localization",
     "semaphore": "// UNSUPPORTED: no-threads, c++03, c++11, c++14, c++17",
     "shared_mutex": "// UNSUPPORTED: no-threads, c++03, c++11",
Index: libcxx/utils/generate_feature_test_macro_components.py
===================================================================
--- libcxx/utils/generate_feature_test_macro_components.py
+++ libcxx/utils/generate_feature_test_macro_components.py
@@ -1179,6 +1179,7 @@
     "locale": ["UNSUPPORTED: no-localization"],
     "mutex": ["UNSUPPORTED: no-threads"],
     "ostream": ["UNSUPPORTED: no-localization"],
+    "print": ["UNSUPPORTED: no-filesystem"],
     "regex": ["UNSUPPORTED: no-localization"],
     "semaphore": ["UNSUPPORTED: no-threads"],
     "shared_mutex": ["UNSUPPORTED: no-threads"],
Index: libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
+++ libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
@@ -11,6 +11,8 @@
 //
 // clang-format off
 
+// UNSUPPORTED: no-filesystem
+
 // <print>
 
 // Test the feature test macros defined by <print>
Index: libcxx/test/std/input.output/iostream.format/print.fun/lit.local.cfg
===================================================================
--- /dev/null
+++ libcxx/test/std/input.output/iostream.format/print.fun/lit.local.cfg
@@ -0,0 +1,2 @@
+if "no-filesystem" in config.available_features:
+    config.unsupported = True


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156585.545319.patch
Type: text/x-patch
Size: 2282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230729/6d038148/attachment.bin>


More information about the libcxx-commits mailing list