[libcxx-commits] [PATCH] D156573: [libcxx] [test] Deduplicate setting parameters for clangcl test configs. NFC.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: Mordante, andrewng.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

This patch is written on top of D155561 <https://reviews.llvm.org/D155561> and D155562 <https://reviews.llvm.org/D155562>, but it can be
rebased and applied first, with the other two coming in on top of
this as well.

I'm undecided about whether this is a good thing or not. The duplicated
logic is clearly not great. But this on the other hand includes a lot
of very obscure variable setting that only makes sense in the context
of the *-clangcl.cfg.in files.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156573

Files:
  libcxx/test/CMakeLists.txt
  libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
  libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in
  libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156573.545280.patch
Type: text/x-patch
Size: 6279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230728/6f42f7a6/attachment.bin>