[libcxx-commits] [PATCH] D155562: [libcxx] [test] Use -fms-runtime-lib= for picking the CRT to use

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 28 13:33:14 PDT 2023


mstorsjo added a comment.

In D155562#4534455 <https://reviews.llvm.org/D155562#4534455>, @andrewng wrote:

> This LGTM but perhaps this should be rolled in with or done after the de-duplication of these test config files?

Dunno - I'm keeping it separate at least, to allow a separate decision on whether such a deduplication (moving more config-specific logic from the test configs into cmake) is a good or bad thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155562/new/

https://reviews.llvm.org/D155562



More information about the libcxx-commits mailing list