[libcxx-commits] [PATCH] D156550: [libc++][test] Fixes using modules in the test suite.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/modules/std.pass.cpp:10
+// UNSUPPORTEd: c++03, c++11, c++14, c++17, c++20
+// XFAIL: c++26
+
----------------
This isn't expected to fail in C++26, right? Could you add a TODO for fixing this?


================
Comment at: libcxx/utils/libcxx/test/dsl.py:460
+    subprocess.check_call([cmake, f"-DCMAKE_CXX_STANDARD={std}", f"-DCMAKE_CXX_FLAGS={flags}", build], env={})
+    subprocess.check_call([cmake, "--build", build, "--", "-v"], env={})
+    config.substitutions = _appendToSubstitution(
----------------
What does the `-v` do?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156550/new/

https://reviews.llvm.org/D156550