[libcxx-commits] [PATCH] D156496: [libunwind] Fix build with -Wunused-function

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

In D156496#4540878 <https://reviews.llvm.org/D156496#4540878>, @philnik wrote:

> I would just mark it `[[maybe_unused]]`. It's not like this is costly to compile.

libunwind builds with C++11 (https://github.com/llvm/llvm-project/blob/2f976b921071cf4349175554f690798a0d2b81f3/libunwind/src/CMakeLists.txt#L140). Dunno if that's intentional or just an oversight. Both gcc and Clang seem to support `[[maybe_unused]]` in C++11 as an extension anyway, but I could use `[[gnu::unused]]` if we want to avoid `-pedantic` warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156496/new/

https://reviews.llvm.org/D156496