[libcxx-commits] [PATCH] D154997: [libc++][hardening] Deprecate `_LIBCPP_ENABLE_ASSERTIONS`.

Thu Jul 27 10:37:21 PDT 2023

dblaikie added a comment.

In D154997#4537439 <https://reviews.llvm.org/D154997#4537439>, @philnik wrote:

> Most libc++ developers (maybe even all right now) don't compile their own toolchain, especially not with assertions enabled.

In D154997#4537661 <https://reviews.llvm.org/D154997#4537661>, @var-const wrote:

> Louis is on vacation, but to echo what Nikolas said, libc++ developers normally don't build `llvm` or `clang`, just `libc++` and a few closely related targets. Not sure why other people building LLVM haven't encountered this, but perhaps they either don't build libc++ and/or don't use `-Werror`?

In D154997#4539515 <https://reviews.llvm.org/D154997#4539515>, @Mordante wrote:

> Debian provides nightly builds of Clang so I don't build Clang myself. And it seems we don't test this in the CI.

Thanks for the perspectives - yeah, I guess as LLVM's gotten larger people have become more specialized/it's not uncommon to be just building one subproject like that. Surprised it didn't turn up on some buildbot then, I guess...

Thanks all!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154997/new/

https://reviews.llvm.org/D154997