[libcxx-commits] [PATCH] D154997: [libc++][hardening] Deprecate `_LIBCPP_ENABLE_ASSERTIONS`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const marked an inline comment as done.
var-const added a comment.

In D154997#4536344 <https://reviews.llvm.org/D154997#4536344>, @dblaikie wrote:

> Looks like this change didn't update https://github.com/llvm/llvm-project/commit/d8e9a1a12557cd5e80c3d713d9cbbba0f7406882 ? At least for me this seems to be causing hard failures when building like this:

Thank you for the heads-up! I'm trying the command you posted locally, but yes, I'm pretty sure that `HandleLLVMOptions.cmake` needs to be updated like you mentioned. Not sure why this hasn't come up sooner -- perhaps other build configurations don't use `-Werror`?

I can work on the fix, or feel free to replace the `_LIBCPP_ENABLE_ASSERTIONS` macro with `_LIBCPP_ENABLE_HARDENED_MODE` if that unblocks you faster.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154997/new/

https://reviews.llvm.org/D154997