[libcxx-commits] [PATCH] D156177: [libc++][Modules] Recreate the top level `std` clang module

Wed Jul 26 14:22:43 PDT 2023

Mordante added a comment.

In D156177#4536314 <https://reviews.llvm.org/D156177#4536314>, @JDevlieghere wrote:

> In D156177#4536299 <https://reviews.llvm.org/D156177#4536299>, @Mordante wrote:
>
>> I'm aware of the policy. However I feel somewhat pressured to approve patch that will not work for some libc++ users.
>
> Yeah, that's totally fair. I personally don't like rushing this either and I don't really have a preference between reverting (which @iana and @ldionne argued against in the original patch) and landing this. I just want our bots to generate signal again after what's now 6 days of being broken.

I understand, and the timing with the release obviously isn't great. I hope we can land a patch tomorrow.

> In D156177#4536299 <https://reviews.llvm.org/D156177#4536299>, @Mordante wrote:
>
>> We spend quite a bit of effort in libc++ to prevent breakage by running an extensive pre-commit CI (±60 jobs). So it's a bit frustrating that we haven't been able to get LLDB working and again discover breakage after a patch has landed. If we need assistance to get LLDB running in the CI can we reach out to you?
>
> Absolutely. Getting pre-commit testing will be a big win for both of our projects.

Thanks a lot!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156177/new/

https://reviews.llvm.org/D156177