[libcxx-commits] [PATCH] D155823: [libcxx] [test] Make set_windows_crt_report_mode.h more explicit

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 26 09:25:01 PDT 2023


Mordante accepted this revision as: libc++.
Mordante added a comment.

In D155823#4529386 <https://reviews.llvm.org/D155823#4529386>, @mstorsjo wrote:

> In D155823#4529184 <https://reviews.llvm.org/D155823#4529184>, @andrewng wrote:
>
>> LGTM, but then again I did author the originating patch, so perhaps someone else also needs to take a look?
>
> Well I also looked at it, so that gives one author and one domain review, so I think that's quite enough.

Agreed, so I'm happy to approve for libc++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155823/new/

https://reviews.llvm.org/D155823



More information about the libcxx-commits mailing list