[libcxx-commits] [PATCH] D156051: [libc++] Renames nasty_macro test.

Wed Jul 26 09:24:48 PDT 2023

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

In D156051#4535662 <https://reviews.llvm.org/D156051#4535662>, @Mordante wrote:

> In D156051#4525962 <https://reviews.llvm.org/D156051#4525962>, @philnik wrote:
>
>> I'm not sure the name is much better. It still doesn't tell me what the test actually tests. Is it that we only use reserved names? Is it to avoid reserved names from other libraries? Maybe something like `system_reserved_names` would be better? I think that is mostly what we are trying to protect against.
>
> System or other compilers, especially MSVC uses quite a number of "nice" __ugly_names as "attributes".
>
> I'm fine with `system_reserved_names`. Do you have other comments? If not then I'll update this patch.

Nope. LGTM with the updated name.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156051/new/

https://reviews.llvm.org/D156051