[libcxx-commits] [PATCH] D155701: [libc++][expected] Implement LWG3836

[Yurong via Phabricator via libcxx-commits]

yronglin marked 3 inline comments as done.
yronglin added a comment.

Thanks for your review and sorry for the very late reply!



================
Comment at: libcxx/include/__expected/expected.h:181
+                       _Not<is_convertible<const expected<_Up, _OtherErr>&, _Tp>>,
+                       _Not<is_convertible<const expected<_Up, _OtherErr>&&, _Tp>> > >,
+
----------------
Mordante wrote:
> This was needed for C++03.
Thanks for the tip, does the header file for C++23 also need this？


================
Comment at: libcxx/include/__expected/expected.h:230
+             !__is_std_unexpected<remove_cvref_t<_Up>>::value && is_constructible_v<_Tp, _Up> &&
+             // LWG3836
+             (!is_same_v<remove_cv_t<_Tp>, bool> || !__is_std_expected<remove_cvref_t<_Up>>::value))
----------------
Mordante wrote:
> We typically don't mention LWG numbers in the code. We use them in the tests.
Thanks, I'll remove this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155701/new/

https://reviews.llvm.org/D155701