[libcxx-commits] [PATCH] D156177: [libc++][Modules] Recreate the top level `std` clang module

Adrian Prantl via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 25 17:28:38 PDT 2023


aprantl added a comment.

In D156177#4533653 <https://reviews.llvm.org/D156177#4533653>, @Bigcheese wrote:

> Changing the name of a module (clang or C++20) is a breaking change, we need to keep importing `std` by name working with Clang modules.

That makes sense and sounds like you support landing this change?

> The Clang module `std` and the C++20 module `std` are different things in that the Clang module includes macros and the full content reachable from the top level headers, while the C++ 20 module does not include macros, and only guarantees a set list of names are visible.

That sounds like a separate issue that could be resolved outside of this patch?

In any case, it would be awesome if we could get the bots running again soon...!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156177/new/

https://reviews.llvm.org/D156177



More information about the libcxx-commits mailing list