[libcxx-commits] [PATCH] D156181: [libc++] Categorize mdspan assertions, and move assertions tests

Tue Jul 25 11:29:09 PDT 2023

crtrott added a comment.

Will ignore the CI failure of the "Module build with local submodule visibility": known common issue with the module cache producing over 1000 errors in the mold of:

  bk;t=1690294997920/home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-49573bbe06a2-1/llvm-project/libcxx-ci/build/generic-modules-lsv/include/c++/v1/__concepts/regular.h:13:2: fatal error: module file '/home/libcxx-builder/.cache/clang/ModuleCache/1BZ5PZK31RHUI/std_private_concepts_semiregular-1920JD1R2UQK3.pcm' is out of date and needs to be rebuilt

  _bk;t=1690294997920   13 | #include <__concepts/semiregular.h>

Mark concurred.

Will also ignore the CI failure for Bootstrapping build based on Mark's input, that this test has issues and will be removed. It failed too here for example: https://buildkite.com/llvm-project/libcxx-ci/builds/28580

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156181/new/

https://reviews.llvm.org/D156181