[libcxx-commits] [PATCH] D156242: [libc++] Removes a broken patch.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D156242#4532561 <https://reviews.llvm.org/D156242#4532561>, @philnik wrote:

> Is this the only test that checks the gdb pretty printer? If yes, then I'm not really comfortable removing it, since we have the gdb pretty printer script too. I realize that it's not tested right now, but having a failing test as a start to fix things is better than having no test at all.

I somewhat agree, but a test that we just disable after we update the LLVM version is not a help either. We haven't tested it for at least clang-15. Having an unused test only gives a false illusion. I added Louis as reviewer since I want to hear his opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156242/new/

https://reviews.llvm.org/D156242