[libcxx-commits] [PATCH] D156177: [libc++][Modules] Recreate the top level `std` clang module

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D156177#4532349 <https://reviews.llvm.org/D156177#4532349>, @aprantl wrote:

>> ! In D156177#4532335 <https://reviews.llvm.org/D156177#4532335>, @Mordante wrote:
>>  I'm not entirely fond of this approach.
>
> Would you mind clarifying what your concerns are?

My main concern is shipping a header to all our users that includes everything without me understanding why. Especially since that was not needed before the changes to modules. Hence my question why this is needed by LLDB.

Smaller concerns, which are fixable

- Something else we need to maintain. We don't often add new top-level headers and I don't see tooling to make sure we don't forget to add it.
- Using a module named `std` which is a C++23 feature


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156177/new/

https://reviews.llvm.org/D156177