[libcxx-commits] [PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D112921#4530916 <https://reviews.llvm.org/D112921#4530916>, @wangpc wrote:

> In D112921#4529182 <https://reviews.llvm.org/D112921#4529182>, @Mordante wrote:
>
>> I noticed some of the CI jobs are still failing with the patch, I didn't look into them.
>
> I don't think they are related to this patch, so I rebased again. If still failed, I will try to fix them later.

I see changes in the libc++ ABI list output

  Symbol added: _ZdlPvmSt11align_val_t
      {'name': '_ZdlPvmSt11align_val_t', 'type': 'FUNC', 'is_defined': False}
  
  Symbol added: _ZdlPvm
      {'name': '_ZdlPvm', 'type': 'FUNC', 'is_defined': False}
  
  SYMBOL REMOVED: _ZdlPvSt11align_val_t
      {'is_defined': False, 'name': '_ZdlPvSt11align_val_t', 'type': 'FUNC'}
  
  Summary
      Added:   2
      Removed: 1
      Changed: 0

There seems to be small change in the symbol name. What does the `m` in the added symbol mean?

  _ZdlPvmSt11align_val_t - added
  _ZdlPvSt11align_val_t  - remove

There is also a new symbol `_ZdlPvm` added.



================
Comment at: clang/test/CodeGenCoroutines/coro-aligned-alloc.cpp:29-31
+// CHECK: %[[coro_size_for_free:.+]] = call{{.*}}@llvm.coro.size
 // CHECK: %[[coro_align_for_free:.+]] = call{{.*}}@llvm.coro.align
+// CHECK: call void @_ZdlPvmSt11align_val_t({{.*}}%[[coro_size_for_free]],{{.*}}%[[coro_align_for_free]])
----------------
Here I see changes in the symbol name. I see issues in the libc++ ABI list too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112921/new/

https://reviews.llvm.org/D112921