[libcxx-commits] [PATCH] D154987: [lit] Implement PYTHON directive and config.prologue

[James Henderson via Phabricator via libcxx-commits]

jhenderson added a comment.

Just chiming in here to give my 2p. lit already has the ability to execute python scripts (call `%python`), but any such scripts are not directly tied into the lit, so running them etc won't produce output that fits with the lit diagnostics, as I understand it. As I understand it, this patch is essentially just an improvement of the "execute arbitrary python script" option. I'm in favour of it, but if it isn't already clear, I think it would be worth outlining in this patch why simply calling an external python script (which could actually be embedded within the file) is insufficient for the motivating case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154987/new/

https://reviews.llvm.org/D154987