[libcxx-commits] [PATCH] D156181: [libc++] Categorize mdspan assertions, and move assertions tests

Christian Trott via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 24 18:11:46 PDT 2023


crtrott updated this revision to Diff 543771.
crtrott added a comment.

Apply review comments: specifically don't check index bounds in layout_left/right since it's double checking when used in mdspan.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156181/new/

https://reviews.llvm.org/D156181

Files:
  libcxx/include/__mdspan/extents.h
  libcxx/include/__mdspan/layout_left.h
  libcxx/include/__mdspan/layout_right.h
  libcxx/include/__mdspan/mdspan.h
  libcxx/test/libcxx/containers/views/mdspan/extents/assert.conversion.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_array.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_integral.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/extents/assert.obs.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.conversion.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.ctor.extents.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.ctor.layout_right.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.index_operator.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.stride.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.conversion.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.ctor.extents.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.ctor.layout_left.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.index_operator.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.stride.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.conversion.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.index_operator.pass.cpp
  libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.size.pass.cpp
  libcxx/test/std/containers/views/mdspan/extents/assert.conversion.pass.cpp
  libcxx/test/std/containers/views/mdspan/extents/assert.ctor_from_array.pass.cpp
  libcxx/test/std/containers/views/mdspan/extents/assert.ctor_from_integral.pass.cpp
  libcxx/test/std/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp
  libcxx/test/std/containers/views/mdspan/extents/assert.obs.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_left/assert.conversion.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_left/assert.ctor.extents.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_left/assert.ctor.layout_right.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_left/assert.index_operator.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_left/assert.stride.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_right/assert.conversion.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_right/assert.ctor.extents.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_right/assert.ctor.layout_left.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_right/assert.index_operator.pass.cpp
  libcxx/test/std/containers/views/mdspan/layout_right/assert.stride.pass.cpp
  libcxx/test/std/containers/views/mdspan/mdspan/assert.conversion.pass.cpp
  libcxx/test/std/containers/views/mdspan/mdspan/assert.index_operator.pass.cpp
  libcxx/test/std/containers/views/mdspan/mdspan/assert.size.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156181.543771.patch
Type: text/x-patch
Size: 28366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230725/2c727095/attachment-0001.bin>


More information about the libcxx-commits mailing list