[libcxx-commits] [PATCH] D156059: [libc++] Fix template parameter naming and enforce it through readability-identifier-naming

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks a lot for working on this! Since this fixes some real bugs it would be great to get in in LLVM 17. This will be branched tomorrow during the European day.



================
Comment at: libcxx/.clang-tidy:53-60
+  - key:   readability-identifier-naming.TemplateParameterCase
+    value: CamelCase
+  - key:   readability-identifier-naming.TemplateParameterPrefix
+    value: _
+  - key:   readability-identifier-naming.TemplateParameterIgnoredRegexp
+    value: (.*\:auto|expr-type) # This is https://llvm.org/PR56464
+  - key:   readability-identifier-naming.ValueTemplateParameterIgnoredRegexp # TODO: enforce naming of variable parameters
----------------
When it's hard to get the CI running soon then maybe undo this hunk and look at it later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156059/new/

https://reviews.llvm.org/D156059