[libcxx-commits] [PATCH] D156051: [libc++] Renames nasty_macro test.

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jul 23 08:45:25 PDT 2023


philnik added a comment.

I'm not sure the name is much better. It still doesn't tell me what the test actually tests. Is it that we only use reserved names? Is it to avoid reserved names from other libraries? Maybe something like `system_reserved_names` would be better? I think that is mostly what we are trying to protect against.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156051/new/

https://reviews.llvm.org/D156051



More information about the libcxx-commits mailing list