[libcxx-commits] [PATCH] D156030: [libc++][doc] Updates format related release notes.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks a lot for the feedback! I'll keep this open for Louis to comment. We can always merge documentation updates directly on the release branch.



================
Comment at: libcxx/docs/ReleaseNotes/17.rst:43
 the C++20 ``chrono`` library lacks supports for time zones and some clocks.
 
 The C++20 spaceship operator is almost complete. It misses ``long double`` and
----------------
avogelsgesang wrote:
> Does it make sense to also mention C++23 improvements and `std::print`?
Yes I noticed that omission after I uploaded the patch and I didn't want to run the CI again.


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:62
 - P2693R1 - Formatting ``thread::id`` (the ``stacktrace`` is not done yet)
 - P2675R1 - ``format``'s width estimation is too approximate and not forward compatible
 - P2505R5 - Monadic operations for ``std::expected``
----------------
avogelsgesang wrote:
> should this be moved down into the `format` specific section?
I prefer to keep the things really new in this section. For users of `-fexperimental-library` this is a new feature.


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:73-74
 
+With the ``format`` library available in the main library the following papers
+are now available in the main library:
+
----------------
avogelsgesang wrote:
> I didn't hear the term "main library" before. Is it supposed to be the opposite of "experimental library"? I think that most users didn't use the experimental library before and might even know of its existence. Hopefully the suggested edit is easier to understand?
> 
> 
Thanks. I was not completely happy with the previous wording too. I like your suggestion.




================
Comment at: libcxx/docs/ReleaseNotes/17.rst:76
+
+- P0645 - Text Formatting
+- P1652 - Printf corner cases in std::format
----------------
avogelsgesang wrote:
> Should the comment on https://libcxx.llvm.org/Status/Cxx20.html#note-p0645 also be updated?
> 
> Or maybe just update the versions from 14.0 to 17.0 and remove the note completely?
> 
> Same for P1652, P1892, P1868, P2216, P2418
I will update the note. For now I keep the version number as is. Since we now use the experimental library more often we need to figure out a way how we can properly document this. IIRC for ranges we basically didn't update much.


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:82
+- P2418 - Add support for std::generator-like types to std::format
+- P2286R8 - Formatting Ranges
+- P2508R1 - Exposing std::basic-format-string
----------------
avogelsgesang wrote:
> The page https://libcxx.llvm.org/Status/Cxx23.html seems to be missing a note for P2286R8 and P2508R1 that they were so far experimental, and claims they were already available in 15.0/16.0
> 
> Update both to 17.0?
Good point. As above we need to discuss how to mark experimental parts in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156030/new/

https://reviews.llvm.org/D156030