[libcxx-commits] [PATCH] D156030: [libc++][doc] Updates format related release notes.

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang added a comment.

Thanks a lot for all the work you have put into implementing `std::format` and `std::print`! It's amazing to see this coming together!



================
Comment at: libcxx/docs/ReleaseNotes/17.rst:43
 the C++20 ``chrono`` library lacks supports for time zones and some clocks.
 
 The C++20 spaceship operator is almost complete. It misses ``long double`` and
----------------
Does it make sense to also mention C++23 improvements and `std::print`?


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:62
 - P2693R1 - Formatting ``thread::id`` (the ``stacktrace`` is not done yet)
 - P2675R1 - ``format``'s width estimation is too approximate and not forward compatible
 - P2505R5 - Monadic operations for ``std::expected``
----------------
should this be moved down into the `format` specific section?


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:65
 - P2711R1 - Making Multi-Param Constructors Of views explicit (``join_with_view`` is not done yet)
 - P2572R1 - ``std::format`` fill character allowances
 - P2510R3 - Formatting pointers
----------------
move down?


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:66
 - P2572R1 - ``std::format`` fill character allowances
 - P2510R3 - Formatting pointers
 - P2136R3 - ``invoke_r``
----------------
move down?


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:69
 - P2494R2 - Relaxing range adaptors to allow for move only types
 - P2585R0 - Improving default container formatting
 - P0408R7 - Efficient Access to ``basic_stringbuf``'s Buffer
----------------
move into new section?


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:73-74
 
+With the ``format`` library available in the main library the following papers
+are now available in the main library:
+
----------------
I didn't hear the term "main library" before. Is it supposed to be the opposite of "experimental library"? I think that most users didn't use the experimental library before and might even know of its existence. Hopefully the suggested edit is easier to understand?




================
Comment at: libcxx/docs/ReleaseNotes/17.rst:76
+
+- P0645 - Text Formatting
+- P1652 - Printf corner cases in std::format
----------------
Should the comment on https://libcxx.llvm.org/Status/Cxx20.html#note-p0645 also be updated?

Or maybe just update the versions from 14.0 to 17.0 and remove the note completely?

Same for P1652, P1892, P1868, P2216, P2418


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:82
+- P2418 - Add support for std::generator-like types to std::format
+- P2286R8 - Formatting Ranges
+- P2508R1 - Exposing std::basic-format-string
----------------
The page https://libcxx.llvm.org/Status/Cxx23.html seems to be missing a note for P2286R8 and P2508R1 that they were so far experimental, and claims they were already available in 15.0/16.0

Update both to 17.0?


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:84
+- P2508R1 - Exposing std::basic-format-string
+
 Improvements and New Features
----------------
Should we also mention the (partial) implementation of P2585R0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156030/new/

https://reviews.llvm.org/D156030