[libcxx-commits] [PATCH] D154367: [libc++] mdspan - implement mdspan class

[Christian Trott via Phabricator via libcxx-commits]

crtrott marked an inline comment as done.
crtrott added inline comments.


================
Comment at: libcxx/include/__mdspan/extents.h:210
   _LIBCPP_HIDE_FROM_ABI constexpr _TDynamic operator[](size_t __i) const {
     _LIBCPP_ASSERT_VALID_ELEMENT_ACCESS(__i < __size_, "extents access: index must be less than rank");
     return __value(__i);
----------------
var-const wrote:
> Can you please double-check if this assertion is tested?
Checked in libcxx/test/std/containers/views/mdspan/extents/assert.obs.pass.cpp


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154367/new/

https://reviews.llvm.org/D154367