[libcxx-commits] [PATCH] D150044: [libc++][print] Adds FILE functions.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 22 09:26:04 PDT 2023


Mordante added inline comments.


================
Comment at: libcxx/src/print.cpp:54
+#    ifndef _LIBCPP_HAS_NO_EXCEPTIONS
+    throw system_error{filesystem::detail::make_windows_error(GetLastError()), "failed to write formatted output"};
+#    else
----------------
ldionne wrote:
> `__throw_system_error`? This way you don't need `ifndef _LIBCPP_HAS_NO_EXCEPTIONS`.
D156019 is the followup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150044/new/

https://reviews.llvm.org/D150044



More information about the libcxx-commits mailing list