[libcxx-commits] [PATCH] D150831: [libc++] Implement ranges::ends_with

[Zijun Zhao via Phabricator via libcxx-commits]

ZijunZhao added inline comments.


================
Comment at: libcxx/include/__algorithm/ranges_ends_with.h:71
+        std::move(__unwrapped2.second),
+        __pred,
+        __proj1,
----------------
var-const wrote:
> `std::ref` should be here.
yes, I tried to pass `std::ref` in `ranges::equal()` and `ranges::start()` only and copy tests failed. And tries to remove `std::ref` when passing to `__ends_with_fn_impl()` and still failed the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150831/new/

https://reviews.llvm.org/D150831