[libcxx-commits] [PATCH] D155866: [libc++][hardening] Don't trigger uncategorized assertions in the hardened mode.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__config:287
 #    define _LIBCPP_ASSERT_INTERNAL(expression, message)               _LIBCPP_ASSUME(expression)
+#    define _LIBCPP_ASSERT_UNCATEGORIZED(expression, message)          _LIBCPP_ASSUME(expression)
 
----------------
var-const wrote:
> ldionne wrote:
> > Mordante wrote:
> > > I noticed there are quite a number of cheap tests in this category. For example `nullptr` guards in `std::string`. Would it make sense to put them in a "cheap-to-test-category". Maybe a `_LIBCPP_ASSERT_PRECONDITION`?
> > I suggest we discuss this in D155873.
> @Mordante I think it would be easier to discuss in the other patch like @ldionne suggested above because it deals with some of those assertions (including the `nullptr` guards in string).
That's fine by me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155866/new/

https://reviews.llvm.org/D155866