[libcxx-commits] [PATCH] D154367: [libc++] mdspan - implement mdspan class

[Christian Trott via Phabricator via libcxx-commits]

crtrott added inline comments.


================
Comment at: libcxx/test/std/containers/views/mdspan/mdspan/index_operator.pass.cpp:42
+// Clang 15 and 16 do not support argument packs as input to operator []
+#if defined(__clang_major__) && __clang_major__ < 17
+template <class MDS>
----------------
ldionne wrote:
> Let's use `TEST_CLANG_VER`, it'll be easier to find in the future and remove the workaround. Also below (and maybe elsewhere, please check).
TEST_CLANG_VER is not defined on apple clang so we would need to check for TEST_CLANG_VER and TEST_APPLECLANG_VER, clang-major works universally here. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154367/new/

https://reviews.llvm.org/D154367