[libcxx-commits] [PATCH] D155880: [libc++] Remove variables that are not necessary anymore inside header_information.py

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 20 13:00:17 PDT 2023


ldionne created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Those are not relevant anymore since we don't have tests for private
headers anymore.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155880

Files:
  libcxx/utils/libcxx/test/header_information.py


Index: libcxx/utils/libcxx/test/header_information.py
===================================================================
--- libcxx/utils/libcxx/test/header_information.py
+++ libcxx/utils/libcxx/test/header_information.py
@@ -59,30 +59,6 @@
     "wctype.h": "// UNSUPPORTED: no-wide-characters",
 }
 
-private_headers_still_public_in_modules = [
-    "__assert",
-    "__config",
-    "__config_site.in",
-    "__hash_table",
-    "__threading_support",
-    "__tree",
-    "__undef_macros",
-    "__verbose_abort",
-]
-
-# Headers that can't be included on their own. Most of these are conceptually
-# part of another header that were split out just for organization, but aren't
-# meant to be included by anything else.
-non_standalone_headers = frozenset((
-    # Alternate implementations for __algorithm/pstl_backends/cpu_backends/backend.h
-    "__algorithm/pstl_backends/cpu_backends/serial.h",
-    "__algorithm/pstl_backends/cpu_backends/thread.h",
-
-    # Alternate implementations for locale.
-    "__locale_dir/locale_base_api/bsd_locale_defaults.h",
-    "__locale_dir/locale_base_api/bsd_locale_fallbacks.h",
-))
-
 # This table was produced manually, by grepping the TeX source of the Standard's
 # library clauses for the string "#include". Each header's synopsis contains
 # explicit "#include" directives for its mandatory inclusions.
@@ -148,9 +124,3 @@
     p.relative_to(include).as_posix() for p in include.glob("experimental/[a-z]*") if is_header(p)
 )
 public_headers = toplevel_headers + experimental_headers
-private_headers = sorted(
-    p.relative_to(include).as_posix() for p in include.rglob("*") if is_header(p)
-                                                                     and str(p.relative_to(include)).startswith("__")
-                                                                     and not p.name.startswith("pstl")
-                                                                     and str(p.relative_to(include)) not in non_standalone_headers
-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155880.542645.patch
Type: text/x-patch
Size: 2005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230720/945d52be/attachment.bin>


More information about the libcxx-commits mailing list