[libcxx-commits] [PATCH] D155760: [libcxx] Fix "copy_move.pass" test

Thu Jul 20 11:36:24 PDT 2023

haowei added a comment.

In D155760#4519028 <https://reviews.llvm.org/D155760#4519028>, @ldionne wrote:

> In D155760#4517443 <https://reviews.llvm.org/D155760#4517443>, @haowei wrote:
>
>> In D155760#4517369 <https://reviews.llvm.org/D155760#4517369>, @mstorsjo wrote:
>>
>>> In D155760#4516691 <https://reviews.llvm.org/D155760#4516691>, @ldionne wrote:
>>>
>>>> LGTM if CI is green.
>>>
>>> Just FWIW, it seems like the premerge CI never ran for this change. As long as all is well and it didn't trip anything up, this was fine, but ideally we should have fixed (setting the "repository" field to "rG <https://reviews.llvm.org/source/llvm-github/>" in the phabricator upload form, which gets set automatically when posting with arcanist) that and made sure the CI actually ran, before pushing it. It looks like the later scheduled runs on main are fine though.
>>
>> I noticed that the premerge bot unexpected timed out when checking out this change and I don't know how to kick it start again. So I just landed it and monitor the post submit bots.
>
> We don't have post-submit bots in libc++. Please make sure to follow these instructions for contributing in the future: https://libcxx.llvm.org/Contributing.html. In particular, using `arc diff` to upload your patch is mandatory for libc++, since it will ensure that CI runs properly.
>
>> I locally test it before I submit the change.
>
> We test 58 configurations in the CI. Local testing is not close to being enough for libc++.

I see. I will follow the instruction next time. Sorry about that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155760/new/

https://reviews.llvm.org/D155760